perf: Partition metadata for parquet statistic loading #18343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ritchie46
requested review from
orlp,
c-peters and
coastalwhite
as code owners
github-actions
bot
added
performance
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #18343 +/- ##
==========================================
- Coverage 79.84% 79.82% -0.03%
==========================================
Files 1496 1496
Lines 200313 200333 +20
Branches 2841 2841
==========================================
- Hits 159942 159916 -26
- Misses 39846 39892 +46
Partials 525 525 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18319
I am convinced we need a metadata supertype so we can amortize this as we need this all over.
We also need the arrow schema to be backed by an
IndexSet. Currently we need a linear search to get a dtype.